-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for VectorInterface to 0.5 for package NDTensors, (keep existing compat) #1588
CompatHelper: bump compat for VectorInterface to 0.5 for package NDTensors, (keep existing compat) #1588
Conversation
…nsors, (keep existing compat)
2108993
to
1cebc5e
Compare
@lkdvos it looks like this may have broken a certain contraction pattern in TensorOperations, I see a failure in this test: https://github.com/ITensor/ITensors.jl/blob/v0.7.3/NDTensors/src/lib/TensorAlgebra/test/test_basics.jl#L163-L165 where we are looping over a number of tensor contraction patterns. |
I'm having trouble reproducing it with a minimal example. |
From what I can see here, this should not related to the compat entry, and really is a bug that probably existed before. I'll have a look in a second |
I see what happened: somehow there is a compat problem, and the installed version of TensorOperations in the failing tests is 0.7.1, which is incredibly outdated. I am not entirely sure why this is happening, as this should probably be excluded by the compat entry of the packages here, since the order of arguments changed. I guess this is because you don't have TensorOperations as a dependency, and thus don't have a compat entry for it? |
As a sidenote, this problem should resolve itself as soon as the tests automatically take the new registered version of TensorOperations, JuliaRegistries/General#119490 |
I see, that would explain it. Thanks for investigating. Yeah, TensorOperations is just being used for testing right now but I guess we could put a compat entry in |
Yes, looks like that fixed it. |
This pull request changes the compat entry for the
VectorInterface
package from0.4.2
to0.4.2, 0.5
for package NDTensors.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.